Fix the output of cnn in DSSM. #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhang2029
changed the title
peterzhang2029
force-pushed
the
dssm_fix
branch
from
287d83e to
9042351
Compare
lcy-seso
reviewed
Dec 11, 2017
dssm/network_conf.py
Outdated
| @@ -151,7 +151,7 @@ def create_conv(context_len, hidden_size, prefix): | |||
| logger.info("create a sequence_conv_pool which context width is 4") | |||
| conv_4 = create_conv(4, self.dnn_dims[1], "cnn") | |||
|
|
|||
| return conv_3, conv_4 | |||
| return paddle.layer.concat(input=[conv_3, conv_4]) | |||
There was a problem hiding this comment.
- Could you please also help to fix the logging information in line 151:
logger.info("create a sequence_conv_pool whose context width is 4.")
- Could you please confirm with @ChunweiYan , is
concatoraddtoneeded here as his original design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #526